Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authentication,optinView): issues/240 optin for all users #255

Merged
merged 1 commit into from
Apr 14, 2020
Merged

fix(authentication,optinView): issues/240 optin for all users #255

merged 1 commit into from
Apr 14, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(authentication,optinView): issues/240 optin for all users

    • authentication, remove admin session checks
    • optinView, remove admin session checks
    • locale, strings updated

Notes

  • Removes the org-admin checks. All users should now see the same thing
  • A 403 from the RHSM API should trigger the "opt-in"
  • A 401 from the RHSM API will trigger an unauthenticated view/message
  • PR Provide a user opt-in form for org-admins #247 Gives the original logic breakdown

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. navigate towards http://localhost:3000/optin
  4. next, submit the form a confirmation screen similar to the below screenshot should appear

Example

Screen Shot 2020-04-09 at 7 32 16 PM

Screen Shot 2020-04-09 at 7 32 25 PM

Screen Shot 2020-04-09 at 7 31 57 PM

Updates issue/story

#240

@cdcabrera
fix(authentication,optinView): issues/240 optin for all users (RedHat…
042e11a 
…Insights#255)

* authentication, remove admin session checks
* optinView, remove admin session checks
* locale, strings updated
@cdcabrera cdcabrera force-pushed the issues/240-nonadmin branch from ea2a48a to 042e11a Compare April 14, 2020 21:07
@cdcabrera cdcabrera merged commit 8819691 into RedHatInsights:ci Apr 14, 2020
@cdcabrera cdcabrera mentioned this pull request Apr 16, 2020
Merged
cdcabrera added a commit that referenced this pull request Apr 17, 2020
@cdcabrera
fix(authentication,optinView): issues/240 optin for all users (#255)
a614d93 
* authentication, remove admin session checks
* optinView, remove admin session checks
* locale, strings updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdcabrera