Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageHeader): update subheading external link icon #369

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

zanewoodfin
Copy link
Contributor

What's included

  • fix(pageHeader): update subheading external link icon
    • pageHeader, update external link icon from ExternalLinkSquareAltIcon to ExternalLinkAltIcon

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. visit /rhel-sw/all and confirm the link icon in the header is correct

Example

external_link_icon

Updates issue/story

Updates #367

@zanewoodfin zanewoodfin linked an issue Aug 5, 2020 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #369 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #369   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          64       64           
  Lines        1528     1528           
  Branches      355      355           
=======================================
  Hits         1413     1413           
  Misses        100      100           
  Partials       15       15           
Impacted Files Coverage Δ
src/components/pageLayout/pageHeader.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f736a...5e576fd. Read the comment docs.

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdcabrera cdcabrera requested a review from bclarhk August 5, 2020 20:46
@bclarhk
Copy link

bclarhk commented Aug 5, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sub heading external link icon
4 participants