Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale string update, issues/389 virtual to virtualized #463

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(locale): issues/389 virtual to virtualized string
  • fix(openshiftView,rhelView): issues/414 inventory link path prefix

How to test

Proxy run check for link updates

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm hovered over the inventory link has the /beta prefix, it was missing before and caused a flip between beta and stable environments

Proxy run check for locale string update

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm that the string "Virtual" is now displayed instead of the string key curiosity-inventory.hardwareType

Example

Link update

Screen Shot 2020-10-19 at 1 45 58 PM (2)

Locale string update

Screen Shot 2020-10-19 at 1 42 09 PM

Updates issue/story

#389 #414

@cdcabrera cdcabrera merged commit 92f86b3 into RedHatInsights:ci Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant