Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inventoryList): issues/389 display cloud providers #467

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(inventoryList): issues/389 display cloud providers
    • locale, cloud provider strings
    • openshiftView, rhelView, activate display for cloud providers
    • inventoryListSelectors, lower case cloud providers for locale context
    • rhsmServices, update mock with cloud provider
    • rhsmApiTypes, expand expected inventory data types

Notes

  • This also updates the "guests" badge to now be called "VMs" and be relocated to the "Name" column

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. log in with an account that has "cloud providers", confirm they're displaying within the "Infrastructure" column

Example

Screen Shot 2020-10-20 at 3 42 06 PM

Updates issue/story

#389

* locale, cloud provider strings
* openshiftView, rhelView, activate display for cloud providers
* inventoryListSelectors, lower case cloud providers for locale context
* rhsmServices, update mock with cloud provider
* rhsmApiTypes, expand expected inventory data types
@cdcabrera cdcabrera merged commit d9065e5 into RedHatInsights:ci Oct 20, 2020
cdcabrera added a commit that referenced this pull request Oct 22, 2020
* locale, cloud provider strings
* openshiftView, rhelView, activate display for cloud providers
* inventoryListSelectors, lower case cloud providers for locale context
* rhsmServices, update mock with cloud provider
* rhsmApiTypes, expand expected inventory data types
cdcabrera added a commit that referenced this pull request Oct 23, 2020
* locale, cloud provider strings
* openshiftView, rhelView, activate display for cloud providers
* inventoryListSelectors, lower case cloud providers for locale context
* rhsmServices, update mock with cloud provider
* rhsmApiTypes, expand expected inventory data types
cdcabrera added a commit that referenced this pull request Oct 27, 2020
* locale, cloud provider strings
* openshiftView, rhelView, activate display for cloud providers
* inventoryListSelectors, lower case cloud providers for locale context
* rhsmServices, update mock with cloud provider
* rhsmApiTypes, expand expected inventory data types
cdcabrera added a commit that referenced this pull request Oct 27, 2020
* locale, cloud provider strings
* openshiftView, rhelView, activate display for cloud providers
* inventoryListSelectors, lower case cloud providers for locale context
* rhsmServices, update mock with cloud provider
* rhsmApiTypes, expand expected inventory data types
cdcabrera added a commit that referenced this pull request Dec 2, 2020
* locale, cloud provider strings
* openshiftView, rhelView, activate display for cloud providers
* inventoryListSelectors, lower case cloud providers for locale context
* rhsmServices, update mock with cloud provider
* rhsmApiTypes, expand expected inventory data types
cdcabrera added a commit that referenced this pull request Dec 2, 2020
* locale, cloud provider strings
* openshiftView, rhelView, activate display for cloud providers
* inventoryListSelectors, lower case cloud providers for locale context
* rhsmServices, update mock with cloud provider
* rhsmApiTypes, expand expected inventory data types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant