Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openshiftView,rhelView): issues/468 sort measurementType #487

Merged
merged 1 commit into from
Nov 3, 2020
Merged

fix(openshiftView,rhelView): issues/468 sort measurementType #487

merged 1 commit into from
Nov 3, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(openshiftView,rhelView): issues/468 sort measurementType
    • inventoryList, enforce sort on specific columns
    • openshiftView, rhelView, activate sorting for measurementType
    • rhsmApiTypes, expand allowed sort types

Notes

  • API dependent, activates the measurementType column sort for inventory
  • Additional check to enforce specific columns being able to sort. Prevent API errors

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. log into an account
  5. attempt to sort by the "Type" column, no errors should be present and the inventory should refresh

Example

Screen Shot 2020-10-29 at 3 51 17 PM

Updates issue/story

Updates #468

@cdcabrera
fix(openshiftView,rhelView): issues/468 sort measurementType
a469c29 
* inventoryList, enforce sort on specific columns
* openshiftView, rhelView, activate sorting for measurementType
* rhsmApiTypes, expand allowed sort types
@cdcabrera cdcabrera marked this pull request as ready for review November 3, 2020 03:48
@cdcabrera
Copy link
Member Author

@ntkathole looks like the API has merged the column sorting for measurement, we good if this PR/MR gets merged?

@ntkathole
Copy link
Member

@cdcabrera yes, backend PR merged.. we are good to merge 👍

@cdcabrera cdcabrera merged commit c670525 into RedHatInsights:qa Nov 3, 2020
@cdcabrera cdcabrera mentioned this pull request Nov 3, 2020
Merged
cdcabrera added a commit that referenced this pull request Dec 2, 2020
@cdcabrera
fix(openshiftView,rhelView): issues/468 sort measurementType (#487)
763b533 
* inventoryList, enforce sort on specific columns
* openshiftView, rhelView, activate sorting for measurementType
* rhsmApiTypes, expand allowed sort types
@cdcabrera cdcabrera mentioned this pull request Dec 2, 2020
Merged
cdcabrera added a commit that referenced this pull request Dec 2, 2020
@cdcabrera
fix(openshiftView,rhelView): issues/468 sort measurementType (#487)
fd757e0 
* inventoryList, enforce sort on specific columns
* openshiftView, rhelView, activate sorting for measurementType
* rhsmApiTypes, expand allowed sort types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @ntkathole