Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): issues/34 correct deployment path prefix (#49) #49

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(build): issues/34 correct deployment path prefix
    • build, deployment path prefix
    • routerTypes, update route, use acronym

How to test basic routing

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Interactive unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test:dev

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. next open up the build directory that was created, you should be able to find these paths with the esi includes...
    • <esi:include src="/apps/chrome/snippets/head.html" />
    • <esi:include src="/apps/chrome/snippets/body.html" />

Check the beta build

  1. you can test check what's produced during a beta branch build, by exporting a "fake" branch value...
    • $ export BRANCH=ci-beta; yarn build
  2. next open up the build directory that was created, you should be able to find these paths with the esi includes...
    • <esi:include src="/beta/apps/chrome/snippets/head.html" />
    • <esi:include src="/beta/apps/chrome/snippets/body.html" />
  3. If you want to reset and try the original build again... you'll have to unset the exported BRANCH value
    • $ unset BRANCH; yarn build

Example

Screen Shot 2019-07-22 at 2 45 43 PM

Screen Shot 2019-07-22 at 2 45 28 PM

Updates issue/story

Updates #34

* build, deployment path prefix
* routerTypes, update route, use acronym
@cdcabrera cdcabrera requested a review from priley86 July 22, 2019 18:46
Copy link
Contributor

@priley86 priley86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the criteria above, no issue from me! Travis env var -> to .env is nifty!

@priley86 priley86 merged commit 34cb100 into RedHatInsights:master Jul 22, 2019
@codecov-io
Copy link

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files          23       23           
  Lines         276      276           
  Branches       59       59           
=======================================
  Hits          237      237           
  Misses         31       31           
  Partials        8        8
Impacted Files Coverage Δ
src/components/router/routerTypes.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1255279...7542547. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants