-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch is shown even if has_cloudigrade_mismatch is false #511
Comments
As per conversation with @cdcabrera, current (18/11/2020) logic is, if any one entry in tally response for particular granularity (i.e. last 30 days record for daily) returns false, then we display mismatch data banner. We should consider only latest (today's date) entry to display this banner else if any user has mismatch in account for 1 day, he/she may see that banner for upcoming 1 month for daily granularity. This may confuse user as even if account mismatch is fixed, page would display mismatch banner. |
@cdcabrera with above fix, we are considering last 2 days for mismatch, but we missed functionality that show notification when mismatch is at filter (sla/usage) level.
and /api/rhsm-subscriptions/v1/tally/products/RHEL?sla=premium returns
|
Good catch @ntkathole we went back and forth on this aspect currently the updated query isn't passed into the banner area. However since it appears "mismatch" appears after the fact we can look at passing the query into the banner message... it'll be based on the query the graph accepts. |
VERIFIED. Functionality looks good
|
Description
"Improve reporting accuracy" notification is displayed even if api returns
has_cloudigrade_mismatch
as false for today's date.Env: QA-beta
Account : swatch-rhui
Expected behavior
"Improve reporting accuracy" notification should display only when
has_cloudigrade_mismatch
is false.Steps to reproduce
Additional context, version info
The text was updated successfully, but these errors were encountered: