fix(build): issues/34 dotenv restructure, correct locale path #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 23 23
Lines 293 293
Branches 60 60
=======================================
Hits 254 254
Misses 31 31
Partials 8 8
Continue to review full report at Codecov.
|
cdcabrera
changed the title
priley86
approved these changes
Jul 25, 2019
* build, dotenv restructure towards .env as primary config * build, locale path fixed * router, minor path update for primary view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
How to test
Coverage and basic unit test check
$ yarn$ yarn testTest the build output
update the NPM packages with
$ yarn$ unset BRANCH; yarn buildthen on the build directory you can do a quick search on the build output to confirm the paths DO NOT start with
/beta/apps$ grep -roi "\"/beta/apps" ./buildTest the build output with the
ci-betabranchupdate the NPM packages with
$ yarn$ export BRANCH=ci-beta; yarn buildthen on the build directory you can do a quick search on the build output to confirm the paths DO start with
/beta/apps$ grep -roi "\"/beta/apps" ./buildExample
...
Updates issue/story
Updates #34