Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(c3Chart): remove c3 and related components #549

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 14, 2021

What's included

  • fix(c3Chart): remove c3 and related components

Notes

  • We're retiring the c3 based set of components. The original purpose was to highlight the ease of implementation between Victory and c3... c3 is easier to implement, but improvements to the Victory components provided by our implementation understanding and Patternfly have made maintaining both Victory and the c3 charts unnecessary.
  • Plus, it appears we may have dropped over a 100+/- kb from the total build output

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate to Subscription Watch and attempt to access c3 by applying the query [subs watch path]?c3... the c3 query parameter should be ignored and no longer display the related chart alternative

Example

...

Updates issue/story

Ongoing
Relates #336

@codecov-io
Copy link

Codecov Report

Merging #549 (6bf8fe3) into ci (5ec1096) will increase coverage by 0.57%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #549      +/-   ##
==========================================
+ Coverage   93.39%   93.97%   +0.57%     
==========================================
  Files          83       80       -3     
  Lines        2151     2391     +240     
  Branches      545      823     +278     
==========================================
+ Hits         2009     2247     +238     
- Misses        119      124       +5     
+ Partials       23       20       -3     
Impacted Files Coverage Δ
src/components/openshiftView/openshiftView.js 92.42% <ø> (-1.58%) ⬇️
src/components/rhelView/rhelView.js 88.09% <ø> (-1.20%) ⬇️
src/components/graphCard/graphCard.js 90.56% <66.66%> (+6.25%) ⬆️
src/components/toolbar/toolbarFieldGranularity.js 90.00% <90.00%> (ø)
src/components/toolbar/toolbarFieldUom.js 100.00% <100.00%> (ø)
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
src/components/router/routerHelpers.js 91.42% <0.00%> (-5.45%) ⬇️
...s/inventorySubscriptions/inventorySubscriptions.js 90.32% <0.00%> (-2.86%) ⬇️
src/redux/selectors/subscriptionsListSelectors.js 97.22% <0.00%> (-2.78%) ⬇️
src/redux/selectors/inventoryListSelectors.js 97.50% <0.00%> (-2.50%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec1096...6bf8fe3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants