Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): ent-3810 flexible to on-demand, fixed to annual #629

Merged
merged 1 commit into from
Apr 21, 2021
Merged

fix(locale): ent-3810 flexible to on-demand, fixed to annual #629

merged 1 commit into from
Apr 21, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 21, 2021 •
edited
Loading

What's included

  • fix(locale): ent-3810 flexible to on-demand, fixed to annual

Notes

  • minor gui strings update for flexible displays

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the strings for OpenShift Container and Dedicated are updated

Example

Screen Shot 2021-04-21 at 4 27 51 PM

Screen Shot 2021-04-21 at 4 28 05 PM

Updates issue/story

ent-3810

@cdcabrera cdcabrera added 202104 project phase docs Improvements or additions to documentation labels Apr 21, 2021
@cdcabrera cdcabrera requested review from bclarhk and jlprevatt April 21, 2021 20:29
@cdcabrera cdcabrera merged commit 16bc6fb into RedHatInsights:ci Apr 21, 2021
@jlprevatt
Copy link
Collaborator

also reviewed, looks good
verified that tooltips for On-Demand and Annual do not contain the flexible/fixed language

cdcabrera added a commit that referenced this pull request Apr 22, 2021
@cdcabrera
fix(locale): ent-3810 flexible to on-demand, fixed to annual (#629)
c595aa5
@cdcabrera cdcabrera mentioned this pull request Apr 22, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 22, 2021
@cdcabrera
fix(locale): ent-3810 flexible to on-demand, fixed to annual (#629)
63d20b3
@cdcabrera cdcabrera mentioned this pull request Apr 22, 2021
Closed
cdcabrera added a commit that referenced this pull request Apr 22, 2021
@cdcabrera
fix(locale): ent-3810 flexible to on-demand, fixed to annual (#629)
b298e46
@cdcabrera cdcabrera mentioned this pull request Apr 22, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 23, 2021
@cdcabrera
fix(locale): ent-3810 flexible to on-demand, fixed to annual (#629)
6e39825
@cdcabrera cdcabrera mentioned this pull request Apr 23, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 26, 2021
@cdcabrera
fix(locale): ent-3810 flexible to on-demand, fixed to annual (#629)
985aa50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bclarhk bclarhk bclarhk approved these changes

@jlprevatt jlprevatt Awaiting requested review from jlprevatt

Assignees
No one assigned
Labels
202104 project phase docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdcabrera @jlprevatt @bclarhk