Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build npm updates #648

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Build npm updates #648

merged 4 commits into from
Apr 29, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(build): npm updates
  • fix(build): react npm updates
  • fix(build): i18n npm updates
  • fix(build): pf, platform npm updates

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm testing throws no errors

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the UI displays as expected

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm the build returns no errors

Example

...

Updates issue/story

Ongoing

@cdcabrera cdcabrera added tech debt We've ignored it this long... build 202104 project phase labels Apr 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #648 (883bc81) into ci (471826c) will decrease coverage by 0.03%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #648      +/-   ##
==========================================
- Coverage   93.81%   93.77%   -0.04%     
==========================================
  Files          86       86              
  Lines        2618     2620       +2     
  Branches      918      923       +5     
==========================================
+ Hits         2456     2457       +1     
  Misses        139      139              
- Partials       23       24       +1     
Impacted Files Coverage Δ
src/components/authentication/authentication.js 72.72% <ø> (ø)
src/components/inventoryList/inventoryList.js 90.54% <ø> (ø)
...s/inventorySubscriptions/inventorySubscriptions.js 89.55% <ø> (ø)
src/components/loader/loader.js 100.00% <ø> (ø)
src/components/pageLayout/pageHeader.js 100.00% <ø> (ø)
src/components/pageLayout/pageMessages.js 100.00% <ø> (ø)
src/components/pageLayout/pageSection.js 100.00% <ø> (ø)
src/components/pageLayout/pageToolbar.js 100.00% <ø> (ø)
src/components/productView/productViewRhel.js 91.42% <ø> (ø)
src/components/productView/productViewSatellite.js 91.42% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 471826c...883bc81. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 28, 2021
@cdcabrera cdcabrera merged commit d51a2bf into RedHatInsights:ci Apr 29, 2021
cdcabrera added a commit that referenced this pull request Apr 29, 2021
cdcabrera added a commit that referenced this pull request Apr 29, 2021
cdcabrera added a commit that referenced this pull request Apr 29, 2021
cdcabrera added a commit that referenced this pull request May 11, 2021
cdcabrera added a commit that referenced this pull request May 11, 2021
cdcabrera added a commit that referenced this pull request May 11, 2021
cdcabrera added a commit that referenced this pull request May 11, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 12, 2021
cdcabrera added a commit that referenced this pull request May 18, 2021
cdcabrera added a commit that referenced this pull request May 18, 2021
cdcabrera added a commit that referenced this pull request May 18, 2021
cdcabrera added a commit that referenced this pull request May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase build tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants