-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): ent-3828 generate permissions from rbac #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
added
bug
Something isn't working
platform
Contains, or is, platform specific work and issues
202108
project phase
labels
May 4, 2021
Codecov Report
@@ Coverage Diff @@
## ci #655 +/- ##
==========================================
- Coverage 93.76% 93.72% -0.04%
==========================================
Files 87 87
Lines 2646 2646
Branches 931 927 -4
==========================================
- Hits 2481 2480 -1
- Misses 141 142 +1
Partials 24 24
Continue to review full report at Codecov.
|
* config, rbac permissions * platformServices, allow appName for getUserPermissions * userSelectors, use permissions instead of hard coded aliases * userServices, allow multiple app permission checks
cdcabrera
added a commit
that referenced
this pull request
May 4, 2021
* config, rbac permissions * docs, contributing.md for local dev * platformApi const, remove unused constants * platformServices, allow appName for getUserPermissions * userSelectors, use config instead of hard coded aliases * userServices, allow multiple app permission checks
cdcabrera
changed the title
fix(rbac): ent-3828 generate permissions from config
feat(config): ent-3828 generate permissions from rbac
May 4, 2021
cdcabrera
added a commit
that referenced
this pull request
May 11, 2021
* config, rbac permissions * docs, contributing.md for local dev * platformApi const, remove unused constants * platformServices, allow appName for getUserPermissions * userSelectors, use config instead of hard coded aliases * userServices, allow multiple app permission checks
cdcabrera
added a commit
that referenced
this pull request
May 12, 2021
* config, rbac permissions * docs, contributing.md for local dev * platformApi const, remove unused constants * platformServices, allow appName for getUserPermissions * userSelectors, use config instead of hard coded aliases * userServices, allow multiple app permission checks
cdcabrera
added a commit
that referenced
this pull request
May 12, 2021
* config, rbac permissions * docs, contributing.md for local dev * platformApi const, remove unused constants * platformServices, allow appName for getUserPermissions * userSelectors, use config instead of hard coded aliases * userServices, allow multiple app permission checks
cdcabrera
added a commit
that referenced
this pull request
May 12, 2021
* config, rbac permissions * docs, contributing.md for local dev * platformApi const, remove unused constants * platformServices, allow appName for getUserPermissions * userSelectors, use config instead of hard coded aliases * userServices, allow multiple app permission checks
cdcabrera
added a commit
that referenced
this pull request
May 18, 2021
* config, rbac permissions * docs, contributing.md for local dev * platformApi const, remove unused constants * platformServices, allow appName for getUserPermissions * userSelectors, use config instead of hard coded aliases * userServices, allow multiple app permission checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
inventory
andhosts
it needs to be confirmed that "read" and only "read" has access to view the interfacereports:read
reports:*
,reports:read
, andreports:write
to all have access. This is now more easily added/removed by editing therbac.json
config fileHow to test
Proxy run check
$ yarn
$ yarn start:proxy
subscriptions
resource =*
operation =*
, all perms (Subscriptions should be available)subscriptions
resource =reports
operation =*
, all perms (Subscriptions should be available)subscriptions
resource =reports
operation =read
, read perms (Subscriptions should be available)subscriptions
resource =reports
operation =write
, write perms (Subscriptions should be available)inventory
resource =hosts
operation =*
, all perms (links for inventory should appear)inventory
resource =hosts
operation =read
, read perms (links for inventory should appear)inventory
resource =hosts
operation =write
, write perms (links for inventory should appear)Example
...
Updates issue/story
ent-3828
relates ENT-2745