Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build, routerTypes): issues/71 disable views config #72

Merged
merged 1 commit into from
Aug 4, 2019

Conversation

cdcabrera
Copy link
Member

What's included

  • feat(build, routerTypes): issues/71 disable views config

Notes

  • applies a view disable option on build
  • Why? For scenarios where e2e is masked against untested scenarios, and/or business value is gained from accurate data.

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Local run check

  1. update the NPM packages with $ yarn
  2. edit the dotenv file .env by changing the line REACT_APP_UI_DISABLED=false to REACT_APP_UI_DISABLED=true
  3. then $ yarn start, you should see an empty view

Example

...

Updates issue/story

Closes #71

@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #72 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   88.74%   88.77%   +0.03%     
==========================================
  Files          23       23              
  Lines         302      303       +1     
  Branches       65       65              
==========================================
+ Hits          268      269       +1     
  Misses         27       27              
  Partials        7        7
Impacted Files Coverage Δ
src/components/router/routerTypes.js 100% <ø> (ø) ⬆️
src/common/helpers.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2760ab2...21b2cf8. Read the comment docs.

@cdcabrera cdcabrera merged commit a4f7da7 into RedHatInsights:master Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable UI
2 participants