fix(build): issues/34 app id, path updates #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 23 23
Lines 303 303
Branches 65 65
=======================================
Hits 269 269
Misses 27 27
Partials 7 7Continue to review full report at Codecov.
|
cdcabrera
changed the title
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Aug 6, 2019
* build, dotenv, package, and proxy config name update * testing, integration checks around naming
priley86
reviewed
Aug 6, 2019
| const { appname } = packageJson.insights; | ||
|
|
||
| const output = execSync(`grep -w "REACT_APP_UI_NAME=${appname}" ${envFile}`); | ||
| expect(output.toString().split('\n')).toMatchSnapshot('ui name'); |
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Aug 6, 2019
* build, dotenv, package, and proxy config name update * testing, integration checks around naming
priley86
approved these changes
Aug 6, 2019
|
Almost good to go, little bit of coordination. We're awaiting the platform PR merge, once that happens we can merge this in. |
* build, dotenv, package, and proxy config name update * testing, integration checks around naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ yarn$ yarn testBuild integration check
$ yarn$ yarn build$ yarn test:integration-devpackage.jsonaroundline 19... changesubscriptionsto something else and watch the tests catch the name change. This is expectedExample
...
Updates issue/story
#34