Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(productView): ent-4247 disable take a tour header button #774

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

cdcabrera
Copy link
Member

What's included

fix(productView): ent-4247 disable take a tour header button

Notes

  • Issues with Pendo being applied after page load combined with a UX/design request to remove the header button means... we've disabled the "Take a tour" button from all existing products. The ability to display the button is still there and will be targeted for removal in a subsequent release.

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm all products NO longer have the "Take a tour" button within the page view header

Screen Shot 2021-08-23 at 4 36 24 PM

Example

...

Updates issue/story

ent-4247

@cdcabrera cdcabrera added bug Something isn't working tech debt We've ignored it this long... 202112 project phase labels Aug 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #774 (185cf1e) into ci (d790d8a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #774   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         101      101           
  Lines        2823     2823           
  Branches     1024     1024           
=======================================
  Hits         2688     2688           
  Misses        128      128           
  Partials        7        7           
Impacted Files Coverage Δ
src/components/productView/productView.js 100.00% <ø> (ø)
src/components/productView/productViewMissing.js 88.88% <ø> (ø)
...nents/productView/productViewOpenShiftContainer.js 84.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d790d8a...185cf1e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase bug Something isn't working tech debt We've ignored it this long...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants