-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rhsmServices,redux): ent-4366 tally refactor for metric id #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c7ed03
to
3f01e69
Compare
Codecov Report
@@ Coverage Diff @@
## ci #822 +/- ##
==========================================
- Coverage 94.92% 94.60% -0.32%
==========================================
Files 109 113 +4
Lines 3012 3152 +140
Branches 1132 1178 +46
==========================================
+ Hits 2859 2982 +123
- Misses 140 155 +15
- Partials 13 15 +2
Continue to review full report at Codecov.
|
* build, jest config * build, joi schema validation for rhsm * dotenv, tally endpoint for metric id * locale, string key updates, match rhsm casing * redux, actions, selector, reducer, helpers, tally refactor * redux, hooks, use multiple selectors with useSelectors * rhsmApiTypes, start move towards rhsm services constants * services, config refactor for transforms, schemas, caching * services, rhsm schemas, transforms, helpers, constants * toolbarFields, string key updates
97f3fdd
to
3a6aef7
Compare
cdcabrera
added a commit
that referenced
this pull request
Nov 29, 2021
* build, jest config * build, joi schema validation for rhsm * dotenv, tally endpoint for metric id * locale, string key updates, match rhsm casing * redux, actions, selector, reducer, helpers, tally refactor * redux, hooks, use multiple selectors with useSelectors * rhsmApiTypes, start move towards rhsm services constants * services, config refactor for transforms, schemas, caching * services, rhsm schemas, transforms, helpers, constants * toolbarFields, string key updates
cdcabrera
added a commit
that referenced
this pull request
Nov 29, 2021
* build, jest config * build, joi schema validation for rhsm * dotenv, tally endpoint for metric id * locale, string key updates, match rhsm casing * redux, actions, selector, reducer, helpers, tally refactor * redux, hooks, use multiple selectors with useSelectors * rhsmApiTypes, start move towards rhsm services constants * services, config refactor for transforms, schemas, caching * services, rhsm schemas, transforms, helpers, constants * toolbarFields, string key updates
cdcabrera
added a commit
that referenced
this pull request
Nov 30, 2021
* build, jest config * build, joi schema validation for rhsm * dotenv, tally endpoint for metric id * locale, string key updates, match rhsm casing * redux, actions, selector, reducer, helpers, tally refactor * redux, hooks, use multiple selectors with useSelectors * rhsmApiTypes, start move towards rhsm services constants * services, config refactor for transforms, schemas, caching * services, rhsm schemas, transforms, helpers, constants * toolbarFields, string key updates
cdcabrera
added a commit
that referenced
this pull request
Dec 6, 2021
* build, jest config * build, joi schema validation for rhsm * dotenv, tally endpoint for metric id * locale, string key updates, match rhsm casing * redux, actions, selector, reducer, helpers, tally refactor * redux, hooks, use multiple selectors with useSelectors * rhsmApiTypes, start move towards rhsm services constants * services, config refactor for transforms, schemas, caching * services, rhsm schemas, transforms, helpers, constants * toolbarFields, string key updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Proxy run check
$ yarn
$ yarn start:proxy
Example
...
Updates issue/story
ent-4366