Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rhsmServices,redux): ent-4366 tally refactor for metric id #822

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 28, 2021

What's included

  • feat(rhsmServices,redux): ent-4366 tally refactor for metric id
    • build, jest config
    • build, joi schema validation for rhsm
    • dotenv, tally endpoint for metric id
    • locale, string key updates, match rhsm casing
    • redux, actions, selector, reducer, helpers, tally refactor
    • redux, hooks, use multiple selectors with useSelectors
    • rhsmApiTypes, start move towards rhsm services constants
    • services, config refactor for transforms, schemas, caching
    • services, rhsm schemas, transforms, helpers, constants
    • toolbarFields, string key updates

Notes

  • There are no visual changes associated with this update.
    • We ended up matching the casing associated with the RHSM api around the strings/enums associated with Granularity, and SLA. If keys for locale strings appear in the associated drop-downs, we missed an update.

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. all tests should come back clean

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the GUI operates as currently intended, there should be no visual changes.
    • We ended up matching the casing associated with the RHSM api around the strings/enums associated with Granularity, and SLA. If keys for locale strings appear in the associated drop-downs, we missed an update and need to update accordingly.

Example

...

Updates issue/story

ent-4366

@cdcabrera cdcabrera added story New feature, or process work 202112 project phase labels Oct 28, 2021
@cdcabrera cdcabrera force-pushed the ent-4366-tally-refactor branch 2 times, most recently from 1c7ed03 to 3f01e69 Compare November 3, 2021 02:00
@cdcabrera cdcabrera changed the title WIP feat(rhsmServices,redux): ent-4366 tally refactor for metric id feat(rhsmServices,redux): ent-4366 tally refactor for metric id Nov 3, 2021
@cdcabrera cdcabrera marked this pull request as ready for review November 3, 2021 02:03
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #822 (e458924) into ci (2e2e994) will decrease coverage by 0.31%.
The diff coverage is 90.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #822      +/-   ##
==========================================
- Coverage   94.92%   94.60%   -0.32%     
==========================================
  Files         109      113       +4     
  Lines        3012     3152     +140     
  Branches     1132     1178      +46     
==========================================
+ Hits         2859     2982     +123     
- Misses        140      155      +15     
- Partials       13       15       +2     
Impacted Files Coverage Δ
src/redux/hooks/useRhsmActions.js 100.00% <ø> (ø)
src/redux/reducers/graphReducer.js 100.00% <ø> (ø)
src/redux/common/reduxHelpers.js 88.15% <77.50%> (-5.28%) ⬇️
src/services/config.js 90.47% <82.60%> (-9.53%) ⬇️
src/services/common/helpers.js 85.18% <85.18%> (ø)
src/redux/actions/rhsmActions.js 100.00% <100.00%> (ø)
src/redux/selectors/graphSelectors.js 100.00% <100.00%> (ø)
src/redux/types/rhsmTypes.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmConstants.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmSchemas.js 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2e994...e458924. Read the comment docs.

* build, jest config
* build, joi schema validation for rhsm
* dotenv, tally endpoint for metric id
* locale, string key updates, match rhsm casing
* redux, actions, selector, reducer, helpers, tally refactor
* redux, hooks, use multiple selectors with useSelectors
* rhsmApiTypes, start move towards rhsm services constants
* services, config refactor for transforms, schemas, caching
* services, rhsm schemas, transforms, helpers, constants
* toolbarFields, string key updates
@cdcabrera cdcabrera force-pushed the ent-4366-tally-refactor branch from 97f3fdd to 3a6aef7 Compare November 8, 2021 06:06
@cdcabrera cdcabrera merged commit 05cff3b into RedHatInsights:ci Nov 8, 2021
cdcabrera added a commit that referenced this pull request Nov 29, 2021
* build, jest config
* build, joi schema validation for rhsm
* dotenv, tally endpoint for metric id
* locale, string key updates, match rhsm casing
* redux, actions, selector, reducer, helpers, tally refactor
* redux, hooks, use multiple selectors with useSelectors
* rhsmApiTypes, start move towards rhsm services constants
* services, config refactor for transforms, schemas, caching
* services, rhsm schemas, transforms, helpers, constants
* toolbarFields, string key updates
cdcabrera added a commit that referenced this pull request Nov 29, 2021
* build, jest config
* build, joi schema validation for rhsm
* dotenv, tally endpoint for metric id
* locale, string key updates, match rhsm casing
* redux, actions, selector, reducer, helpers, tally refactor
* redux, hooks, use multiple selectors with useSelectors
* rhsmApiTypes, start move towards rhsm services constants
* services, config refactor for transforms, schemas, caching
* services, rhsm schemas, transforms, helpers, constants
* toolbarFields, string key updates
cdcabrera added a commit that referenced this pull request Nov 30, 2021
* build, jest config
* build, joi schema validation for rhsm
* dotenv, tally endpoint for metric id
* locale, string key updates, match rhsm casing
* redux, actions, selector, reducer, helpers, tally refactor
* redux, hooks, use multiple selectors with useSelectors
* rhsmApiTypes, start move towards rhsm services constants
* services, config refactor for transforms, schemas, caching
* services, rhsm schemas, transforms, helpers, constants
* toolbarFields, string key updates
cdcabrera added a commit that referenced this pull request Dec 6, 2021
* build, jest config
* build, joi schema validation for rhsm
* dotenv, tally endpoint for metric id
* locale, string key updates, match rhsm casing
* redux, actions, selector, reducer, helpers, tally refactor
* redux, hooks, use multiple selectors with useSelectors
* rhsmApiTypes, start move towards rhsm services constants
* services, config refactor for transforms, schemas, caching
* services, rhsm schemas, transforms, helpers, constants
* toolbarFields, string key updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase story New feature, or process work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants