Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(optinView): ent-4572 convert class component #877

Merged
merged 1 commit into from
Jan 31, 2022
Merged

refactor(optinView): ent-4572 convert class component #877

merged 1 commit into from
Jan 31, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 26, 2022 •
edited
Loading

What's included

  • refactor(optin): ent-4572 convert class component

Notes

  • there should be no visual or behavioral changes associated with this update

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm existing unit tests for optinView pass
    • * original unit tests and snapshots were used as the baseline for behavior

Example

...

Updates issue/story

ent-4572

@cdcabrera cdcabrera added the 202204 project phase label Jan 26, 2022
@cdcabrera cdcabrera changed the title WIP refactor(optinView): ent-4572 convert class component refactor(optinView): ent-4572 convert class component Jan 31, 2022
@cdcabrera cdcabrera marked this pull request as ready for review January 31, 2022 20:39
@cdcabrera cdcabrera merged commit d62b121 into RedHatInsights:ci Jan 31, 2022
@cdcabrera cdcabrera mentioned this pull request Mar 1, 2022
Merged
cdcabrera added a commit that referenced this pull request Mar 1, 2022
@cdcabrera
refactor(optinView): ent-4572 convert class component (#877)
bc93c94
@cdcabrera cdcabrera mentioned this pull request Mar 3, 2022
Merged
cdcabrera added a commit that referenced this pull request Mar 8, 2022
@cdcabrera
refactor(optinView): ent-4572 convert class component (#877)
2d0a63b
@cdcabrera cdcabrera mentioned this pull request Mar 8, 2022
Merged
cdcabrera added a commit that referenced this pull request Mar 8, 2022
@cdcabrera
refactor(optinView): ent-4572 convert class component (#877)
39f9c2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202204 project phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdcabrera