Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(platform,userServices): ent-4669 restructure dir #879

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Feb 1, 2022

What's included

  • refactor(platform,userServices): ent-4669 restructure dir
    • platform,userServices, dir consistency
    • rhsmTransformers, spelling
  • fix(serviceConfig): caching reset on config update
    • config, resets response cache when props are updated
    • testing, expand testing baseline for config rewrite
  • feat(serviceConfig): ent-4669 mock service calls via functions

Notes

  • 1.X of 2 issues, this part being the restructure, refactor for providing the user session as React context. Part 1 was ENT-4572 class to function conversion in prep for hooks
    • this part establishes the directory restructure
    • fixes a potential issue discovered while expanding the testing baseline for a config rewrite
    • and adds a function as service feature that'll be used when we start piping global platform methods MORE directly through our service layer (currently the global methods have wrappers but called through Redux actions and potentially transformed through selectors... this allows us to apply transformations similar to API responses)
  • there are no visual updates associated with this PR

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm the GUI renders as expected across existing products without error

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the GUI renders as expected across existing products without error

Example

...

Updates issue/story

ent-4669

@cdcabrera cdcabrera added the 202204 project phase label Feb 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #879 (22d19da) into ci (bff0953) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #879      +/-   ##
==========================================
+ Coverage   94.07%   94.32%   +0.25%     
==========================================
  Files         126      126              
  Lines        3694     3719      +25     
  Branches     1445     1459      +14     
==========================================
+ Hits         3475     3508      +33     
+ Misses        201      195       -6     
+ Partials       18       16       -2     
Impacted Files Coverage Δ
src/redux/actions/platformActions.js 100.00% <ø> (ø)
src/redux/actions/userActions.js 100.00% <ø> (ø)
src/redux/selectors/userSelectors.js 100.00% <ø> (ø)
src/services/platform/platformServices.js 97.61% <ø> (ø)
src/services/user/userServices.js 94.59% <ø> (ø)
src/types/index.js 100.00% <ø> (ø)
src/services/config.js 100.00% <100.00%> (+14.28%) ⬆️
src/services/platform/platformConstants.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmServices.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmTransformers.js 95.65% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff0953...22d19da. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 1, 2022
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 1, 2022
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 1, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 1, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 3, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 25, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 28, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 2, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 2, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
@cdcabrera cdcabrera changed the title WIP refactor(authentication): ent-4669 session context refactor(platform,userServices): ent-4669 restructure dir Mar 2, 2022
@cdcabrera cdcabrera marked this pull request as ready for review March 2, 2022 18:55
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 2, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 2, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 3, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 3, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 8, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 8, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 8, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 9, 2022
…ghts#879)

* platform,userServices, dir consistency
* rhsmTransformers, spelling
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
@cdcabrera cdcabrera merged commit 3fa6b09 into RedHatInsights:ci Mar 9, 2022
cdcabrera added a commit that referenced this pull request Mar 9, 2022
* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit that referenced this pull request Mar 9, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
cdcabrera added a commit that referenced this pull request Apr 14, 2022
* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit that referenced this pull request Apr 14, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
@cdcabrera cdcabrera mentioned this pull request Apr 14, 2022
cdcabrera added a commit that referenced this pull request Apr 19, 2022
* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit that referenced this pull request Apr 19, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* platform,userServices, dir consistency
* rhsmTransformers, spelling
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* config, resets response cache when props are updated
* testing, expand testing baseline for config rewrite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants