Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authenticationContext): ent-4669 context, useSession hooks #915

Merged
merged 4 commits into from
Apr 7, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 4, 2022

What's included

  • feat(authenticationContext): ent-4669 context, useSession hooks
    • app, refactor towards userReducer update
    • authentication, refactor for context, useSession
    • authenticationContext, useAuth, useSession hooks
    • inventoryCard, Guests, optInView refactor for useSession
    • productView, update connected inventory import
    • userReducer, refactor shallow structure, prep for rename
    • userSelectors, refactor towards userReducer update
    • rhsmConstants, error response

Notes

  • this updates the user facet of our Redux store to allow for use with authentication context, session value hooks
  • we still need to maintain the old userSelectors until the inventoryList and guestsList deprecated components are removed. after those two components are retired in favor of the metrics update used by the instances endpoint we should be able to remove several selectors

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm there is no change in behavior across products

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm there is no change in behavior across products

Example

...

Updates issue/story

ent-4669

@cdcabrera cdcabrera added the 202204 project phase label Apr 4, 2022
* app, refactor towards userReducer update
* authentication, refactor for context, useSession
* authenticationContext, useAuth, useSession hooks
* inventoryCard, Guests, optInView refactor for useSession
* productView, update connected inventory import
* userReducer, refactor shallow structure, prep for rename
* userSelectors, refactor towards userReducer update
* rhsmConstants, error response
@cdcabrera cdcabrera force-pushed the ent-4669-sel-session branch from 6219f70 to ca9b84f Compare April 5, 2022 23:17
@cdcabrera cdcabrera marked this pull request as ready for review April 5, 2022 23:17
@cdcabrera cdcabrera changed the title WIP feat(authenticationContext): ent-4669 auth context, useSession hook feat(authenticationContext): ent-4669 auth context, useSession hook Apr 5, 2022
@cdcabrera cdcabrera changed the title feat(authenticationContext): ent-4669 auth context, useSession hook feat(authenticationContext): ent-4669 context, useSession hooks Apr 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #915 (614a3dd) into ci (1af54fe) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #915      +/-   ##
==========================================
+ Coverage   94.06%   94.11%   +0.05%     
==========================================
  Files         129      130       +1     
  Lines        3928     3945      +17     
  Branches     1538     1545       +7     
==========================================
+ Hits         3695     3713      +18     
+ Misses        216      215       -1     
  Partials       17       17              
Impacted Files Coverage Δ
src/components/productView/productView.js 94.11% <ø> (ø)
src/components/authentication/authentication.js 96.66% <100.00%> (+0.11%) ⬆️
...components/authentication/authenticationContext.js 100.00% <100.00%> (ø)
src/components/inventoryCard/inventoryCard.js 100.00% <100.00%> (ø)
src/components/inventoryGuests/inventoryGuests.js 83.33% <100.00%> (-0.39%) ⬇️
src/components/optinView/optinView.js 100.00% <100.00%> (ø)
src/redux/actions/userActions.js 100.00% <100.00%> (ø)
src/redux/reducers/userReducer.js 100.00% <100.00%> (ø)
src/redux/selectors/userSelectors.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmConstants.js 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af54fe...614a3dd. Read the comment docs.

@cdcabrera cdcabrera merged commit 4e74187 into RedHatInsights:ci Apr 7, 2022
cdcabrera added a commit that referenced this pull request Apr 14, 2022
* app, refactor towards userReducer update
* authentication, refactor for context, useSession
* authenticationContext, useAuth, useSession hooks
* inventoryCard, Guests, optInView refactor for useSession
* productView, update connected inventory import
* userReducer, refactor shallow structure, prep for rename
* userSelectors, refactor towards userReducer update
* rhsmConstants, error response
@cdcabrera cdcabrera mentioned this pull request Apr 14, 2022
cdcabrera added a commit that referenced this pull request Apr 19, 2022
* app, refactor towards userReducer update
* authentication, refactor for context, useSession
* authenticationContext, useAuth, useSession hooks
* inventoryCard, Guests, optInView refactor for useSession
* productView, update connected inventory import
* userReducer, refactor shallow structure, prep for rename
* userSelectors, refactor towards userReducer update
* rhsmConstants, error response
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* app, refactor towards userReducer update
* authentication, refactor for context, useSession
* authenticationContext, useAuth, useSession hooks
* inventoryCard, Guests, optInView refactor for useSession
* productView, update connected inventory import
* userReducer, refactor shallow structure, prep for rename
* userSelectors, refactor towards userReducer update
* rhsmConstants, error response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants