Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useReactRedux): ent-4669 expand useSelectorsResponse #916

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 4, 2022

What's included

  • refactor(useReactRedux): ent-4669 expand useSelectorsResponse
  • fix(styling): hide header expand collapse icon

Notes

  • Minor CSS correction related to recent package updates. We still can't pinpoint exactly whether the behavior is actually appearing in prod and staging environments. The CSS was minor so this is more of a "preemptive" fix, see below Patternfly behavior screenshot for the arrow in the table header row.
  • Refactors useSelectorsResponse to more closely mirror a Promise.all response. This PR also expands useSelectorsResponse to now include Promise.allSettled, Promise.any, and Promise.race behavior hooks.

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm
    • the "streams" product view's inventory behavior for both Instances and Subscriptions table displays remains consistent and unaltered
    • the optin process behavior remains consistent and unaltered

Example

CSS Fix prevents this behavior

Screen Shot 2022-03-31 at 4 52 04 PM

Updates issue/story

ent-4669

@cdcabrera cdcabrera added the 202204 project phase label Apr 4, 2022
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Apr 5, 2022
@cdcabrera cdcabrera force-pushed the ent-4669-useselectorresponse branch from abbf3bf to 2d442e0 Compare April 5, 2022 14:23
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #916 (32120c4) into ci (30cd756) will decrease coverage by 0.30%.
The diff coverage is 93.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #916      +/-   ##
==========================================
- Coverage   94.39%   94.09%   -0.31%     
==========================================
  Files         129      129              
  Lines        3764     3928     +164     
  Branches     1474     1538      +64     
==========================================
+ Hits         3553     3696     +143     
- Misses        195      215      +20     
- Partials       16       17       +1     
Impacted Files Coverage Δ
src/redux/hooks/useReactRedux.js 93.71% <93.22%> (-6.29%) ⬇️
...mponents/inventoryGuests/inventoryGuestsContext.js 85.71% <0.00%> (-9.53%) ⬇️
...c/components/inventoryCard/inventoryCardContext.js 83.67% <0.00%> (-8.17%) ⬇️
src/components/productView/productViewContext.js 94.52% <0.00%> (-1.37%) ⬇️
src/common/helpers.js 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cd756...32120c4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants