Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ent-4669 clean up, test updates #922

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(pageHeader): clean up unused take a tour
  • fix(inventoryCardSubscriptions): clean up props, inventory tests
  • feat(serviceConfig,helpers): ent-4669 pass config for transformers

Notes

  • minor non-visual clean up of components, tests

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm products render as expected

Example

...

Updates issue/story

ent-4669

@cdcabrera cdcabrera added the 202204 project phase label Apr 12, 2022
@cdcabrera cdcabrera force-pushed the ent-4669-sidetasks branch from bfff5f0 to d1cb1d6 Compare April 12, 2022 18:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #922 (d1cb1d6) into ci (650aab1) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #922      +/-   ##
==========================================
+ Coverage   94.02%   94.32%   +0.29%     
==========================================
  Files         130      130              
  Lines        3967     3964       -3     
  Branches     1552     1550       -2     
==========================================
+ Hits         3730     3739       +9     
+ Misses        220      208      -12     
  Partials       17       17              
Impacted Files Coverage Δ
src/services/common/serviceConfig.js 98.83% <ø> (ø)
...oryCardSubscriptions/inventoryCardSubscriptions.js 100.00% <100.00%> (ø)
src/components/pageLayout/pageHeader.js 100.00% <100.00%> (ø)
src/services/common/helpers.js 92.30% <100.00%> (+2.56%) ⬆️
src/common/helpers.js 100.00% <0.00%> (+1.66%) ⬆️
src/components/productView/productViewContext.js 97.26% <0.00%> (+2.73%) ⬆️
...Subscriptions/inventoryCardSubscriptionsContext.js 81.63% <0.00%> (+8.16%) ⬆️
...c/components/inventoryCard/inventoryCardContext.js 91.83% <0.00%> (+8.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650aab1...d1cb1d6. Read the comment docs.

@cdcabrera cdcabrera merged commit deb43c3 into RedHatInsights:ci Apr 13, 2022
cdcabrera added a commit that referenced this pull request Apr 14, 2022
* serviceConfig, helpers config to transformers, include params
@cdcabrera cdcabrera mentioned this pull request Apr 14, 2022
cdcabrera added a commit that referenced this pull request Apr 19, 2022
* serviceConfig, helpers config to transformers, include params
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* serviceConfig, helpers config to transformers, include params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202204 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants