Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): ephemeral envs, skip dist check #937

Merged
merged 3 commits into from
May 25, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented May 25, 2022

What's included

  • chore(testing): ephemeral envs, skip dist check
  • chore(testing): allow skipping individual tests
  • build(dev,proxy,prod): remove unused html template

Notes

  • Cleans up unused HTML template and webpack config
    • With updates to @redhat-cloud-services/frontend-components-config v4.6.9+ we no longer need to maintain our own HTML template, we updated in PR chore(build): npm updates #930
  • Skips the integration dist check associated with ephemeral envs. @mirekdlugosz
    • We're having to make an educated guess that the containerized build is applying a base image which in turn causes the build output to alter. It's not great disabling a confirmation check we've used for the past few years but that check is still going be allowed to run against our GitHub actions... just removing some duplication in effort...
    • That segues into the level of repetition in testing that's happening between GitHub actions, Travis, and containerized checks. We'll need to review how much we really need to duplicate in our ephemeral test checks if GitHub actions is also running. This is something we started to do for the Travis facet but decided to just let it provide duplicated effort.
    • GitHub actions is still our preferred path for running consistent, fast, multi-nodejs dev level unit tests and integration checks.

How to test

Confirm bot checks

  1. Confirm the ci.ext.devshit.net PR build bot is passing

Example

...

Updates issue/story

Ongoing

@cdcabrera cdcabrera added build 202208 project phase labels May 25, 2022
Copy link
Member Author

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor update to package.json

package.json Outdated Show resolved Hide resolved
* webpack, html template is provided by frontend config
* build, expand clean up to dist
@cdcabrera cdcabrera merged commit 5070158 into RedHatInsights:ci May 25, 2022
cdcabrera added a commit that referenced this pull request May 25, 2022
* webpack, html template is provided by frontend config
* build, expand clean up to dist
cdcabrera added a commit that referenced this pull request May 25, 2022
* webpack, html template is provided by frontend config
* build, expand clean up to dist
cdcabrera added a commit that referenced this pull request May 26, 2022
* webpack, html template is provided by frontend config
* build, expand clean up to dist
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* webpack, html template is provided by frontend config
* build, expand clean up to dist
@cdcabrera cdcabrera mentioned this pull request Jun 14, 2022
cdcabrera added a commit that referenced this pull request Jun 24, 2022
* webpack, html template is provided by frontend config
* build, expand clean up to dist
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* webpack, html template is provided by frontend config
* build, expand clean up to dist
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* webpack, html template is provided by frontend config
* build, expand clean up to dist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant