Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Serializing subreports to JSON only once even if the global report is decorated. #117

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

ehsavoie
Copy link
Collaborator

No description provided.

@ehsavoie ehsavoie force-pushed the memory branch 2 times, most recently from b529c2e to f09c2b1 Compare June 30, 2023 16:22
@ehsavoie ehsavoie marked this pull request as ready for review July 20, 2023 15:40
@jponge
Copy link
Collaborator

jponge commented Jul 21, 2023

@ehsavoie Commits / PR title will have to be fixed

@ehsavoie ehsavoie changed the title Memory fix: Serializing subreports to JSON only once even if the global report is decorated. Jul 21, 2023
@ehsavoie ehsavoie changed the title fix: Serializing subreports to JSON only once even if the global report is decorated. fix:Serializing subreports to JSON only once even if the global report is decorated. Jul 21, 2023
Removing the use of serialize and using serializeRaw instead

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Copy link
Collaborator

@jponge jponge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've done a review with @ehsavoie.

Minor fixes to be applied:

  • add a missing comment on the subreport rewrite trick
  • deprecated the String-returning serialize() method

You can then merge @ehsavoie 👍

…t is decorated..

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants