RHINENG-14556 remove old code to keep the new service independent #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r14chandra
force-pushed
the
RHINENG-14556
branch
2 times, most recently
from
cbb58a4 to
b498bb9
Compare
r14chandra
force-pushed
the
RHINENG-14556
branch
from
b498bb9 to
3e2fca6
Compare
|
/retest |
|
@r14chandra I can see we have not touched the models, so with this pr my impression is we go with current models as is and later on tweak it as per requirements? |
upadhyeammit
reviewed
Dec 2, 2024
r14chandra
force-pushed
the
RHINENG-14556
branch
from
5605e0a to
297c742
Compare
Yes, that's true. It’s also possible that what I am removing right now may be needed later. |
upadhyeammit
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need this change? 💭
Eliminating codes that are not necessary for the new backend.
Documentation update? 📝
Security Checklist 🔒
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
💂♂️ Checklist 🎯
Additional 📣
Feel free to add any other relevant details such as links, notes, screenshots, here.