-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SystemsTable): Fix resetting to default filters #1985
fix(SystemsTable): Fix resetting to default filters #1985
Conversation
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
d6b9fb6
to
454e84a
Compare
454e84a
to
eb9c80e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing this PR, I've found an issue with the reset button.
If you add OS filters, and then select 'reset filters' button, the filters/chips are no longer removed
@adonispuente Thank you for taking a look and testing! The resetting should now work properly in any case! Would you mind taking another looksie? |
210e50e
to
dfee2c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as intended, LGTM!
## [1.104.4](v1.104.3...v1.104.4) (2023-09-25) ### Bug Fixes * **SystemsTable:** Fix resetting to default filters ([#1985](#1985)) ([6201326](6201326))
## [1.104.4](RedHatInsights/vulnerability-ui@v1.104.3...v1.104.4) (2023-09-25) ### Bug Fixes * **SystemsTable:** Fix resetting to default filters ([#1985](RedHatInsights/vulnerability-ui#1985)) ([6201326](RedHatInsights/vulnerability-ui@6201326))
This fixes resetting the filters to the default filters on the Systems page.