Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message key to the Kafka messages for adding hosts #126

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thearifismail
Copy link

@JoySnow This is my suggestion. Jist of the matter is the uploaded kafka message should have "key": "<org-d>"

@thearifismail thearifismail marked this pull request as draft December 10, 2024 17:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.40%. Comparing base (c7a7526) to head (b09f6de).

Files with missing lines Patch % Lines
yuptoo/lib/produce.py 25.00% 3 Missing ⚠️
yuptoo/processor/report_processor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   78.53%   78.40%   -0.13%     
==========================================
  Files          23       23              
  Lines         615      616       +1     
==========================================
  Hits          483      483              
- Misses        132      133       +1     
Flag Coverage Δ
unittests 78.40% <20.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants