Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We propose to use
url-template
instead ofuri-template-lite
.uri-template-lite
seems to be vulnerable for a XSS attack as stated in #1007. I agree this dependency is less maintained thenuri-template-lite
. However, as the approach of this dependency is to generate code on runtime, probably to speed it up (therefore the '-lite'), we do not consider it 'safe'.Also corrected a test that was not conform the spec, and detected by the new
url-template
dependency:Therefore, the following test does not seems to be correct:
should be:
If you have any questions, let me know. We do like Redoc, but we have to comply to serious security policies.