Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1286: Expand/Collapse all buttons disappears for flat structures #1424

Merged

Conversation

AvroraPolnareff
Copy link
Contributor

Hi, I've done work on issue #1286. I think toggle only buttons visibility is easier way to implement this. Let me know if you prefer something else.

Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few corrections to properly handle null values

src/components/JsonViewer/JsonViewer.tsx Outdated Show resolved Hide resolved
src/components/JsonViewer/JsonViewer.tsx Outdated Show resolved Hide resolved
src/components/__tests__/JsonViewer.tsx Outdated Show resolved Hide resolved
Co-authored-by: Roman Hotsiy <gotsijroman@gmail.com>
Copy link
Contributor Author

@AvroraPolnareff AvroraPolnareff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works fine, I've added suggestions to pull request.

src/components/JsonViewer/JsonViewer.tsx Outdated Show resolved Hide resolved
@AvroraPolnareff AvroraPolnareff requested a review from a team as a code owner April 20, 2022 15:10
@AvroraPolnareff AvroraPolnareff requested review from AlexVarchuk and zalesky and removed request for a team April 20, 2022 15:10
@zalesky
Copy link
Contributor

zalesky commented Apr 22, 2022

Screenshot 2022-04-22 at 11 48 08

LGTM

@AvroraPolnareff, Thanks for your input 👍

@zalesky
Copy link
Contributor

zalesky commented Apr 22, 2022

@RomanHotsiy Would you kindly unblock this?

@anastasiia-developer anastasiia-developer merged commit 2ca8e08 into Redocly:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants