Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handled style change in ServerUrl and ServersOverlay dynamically #1989

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

pranitkhadilkar7
Copy link
Contributor

fix: handled style change in ServerUrl and ServersOverlay dynamically

What/Why/How?

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

fix: handled style change in ServerUrl and ServersOverlay dynamically
@pranitkhadilkar7 pranitkhadilkar7 requested a review from a team as a code owner May 10, 2022 12:50
@pranitkhadilkar7 pranitkhadilkar7 requested review from AlexVarchuk and zalesky and removed request for a team May 10, 2022 12:50
Copy link
Collaborator

@AlexVarchuk AlexVarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranitkhadilkar7 Hi! Thank you for your contribution to Redoc 🙌 .
It is better to add a new object with these options to rightPanel instead of using sidebar panel options.
Something like that

servers: {
  color: 263238,
  ....
}

@pranitkhadilkar7
Copy link
Contributor Author

@AlexVarchuk, thank you for your valuable feedback. I have updated the code as per your review comments. Please do the review and let me know if further changes are required.

Copy link
Collaborator

@AlexVarchuk AlexVarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@pranitkhadilkar7 Thank you for the quick update. We very much appreciate your contribution.

@AlexVarchuk
Copy link
Collaborator

theme: {
    rightPanel: {
      servers: {
        overlay: { backgroundColor: 'blue', textColor: 'red' },
        url: { backgroundColor: 'black' },
      },
    },
  }

Screenshot 2022-06-01 at 14 47 00

@AlexVarchuk AlexVarchuk merged commit a366de4 into Redocly:master Jun 1, 2022
@AlexVarchuk
Copy link
Collaborator

merged
@pranitkhadilkar7 thank you for your contribution 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants