feat: remove auth section #2022
Conversation
anastasiia-developer
requested review from
AlexVarchuk,
zalesky and
Oprysk
and removed request for
a team
There was a problem hiding this comment.
Should we deprecate noAutoAuth? What do you think? @anastasiia-developer @RomanHotsiy @Oprysk
| { openapi: '3.0', info: { title: 'test', version: '0' }, paths: {} }, | ||
| undefined, | ||
| options, | ||
| const spec: OpenAPISpec = { |
There was a problem hiding this comment.
Maybe better move spec to fixtures?
There was a problem hiding this comment.
Does it cover all security types, which we support?
oauth2: 'OAuth2',
apiKey: 'API Key',
http: 'HTTP',
openIdConnect: 'OpenID Connect',
There was a problem hiding this comment.
Maybe better move spec to fixtures?
Done 😄
…nto feat/remove_auth_section
|
Are these screenshots updated? I see too much vertical gap between |
| RequiredScopes?: JSX.Element; | ||
| } | ||
|
|
||
| export class OAuthFlow extends React.PureComponent<OAuthFlowProps> { |
There was a problem hiding this comment.
It would be great to use functional component here
There was a problem hiding this comment.
@anastasiia-developer Previously it was a PureComponent after refactoring it to the function component we need to keep the performance in the rendering perspective. So we might use React memo HOC here, what do you think?
There was a problem hiding this comment.
yes, we might
I'm going to add that
What/Why/How?
feat: remove auth section
Reference
Testing
Screenshots (optional)
Security unexpanded
Security expanded
See more
See less
Check yourself