fix: do not use discriminator when specific schema was referenced in oneOf or anyOf #2153
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHotsiy
requested review from
AlexVarchuk
and removed request for
a team
RomanHotsiy
force-pushed
the
fix-direct-disriminator-in-anyof
branch
from
6b1c56b
to
d0c110e
Compare
RomanHotsiy
force-pushed
the
fix-direct-disriminator-in-anyof
branch
from
d0c110e
to
6c10de6
Compare
AlexVarchuk
approved these changes
Sep 6, 2022
This was referenced Jul 16, 2024
This was referenced Jul 25, 2024
This was referenced Aug 1, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
When specific child schema is mentioned in anyOf or oneOf most likely it is meant to be the specific instance and not be discriminated.
Reference
Fixes #2133
Testing
Added a test.
Check yourself