Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List core-js as a dev dependency to install when working with React #814

Closed
kojidev opened this issue Feb 11, 2019 · 5 comments
Closed

List core-js as a dev dependency to install when working with React #814

kojidev opened this issue Feb 11, 2019 · 5 comments

Comments

@kojidev
Copy link

kojidev commented Feb 11, 2019

I've been following the steps of integrating the Redoc into react app, and it asks to install styled-components and mobx above react and react-dom, but the code also uses core-js/es6/promise module but it is not listed in installation doc.

@brendancf
Copy link

is there a workaround or fix for this?

@kojidev
Copy link
Author

kojidev commented Jun 12, 2019

@brendancf just add it into your project as a dependency, my issue is that it is not listed anywhere, you have to figure out yourself

@brendancf
Copy link

brendancf commented Jun 12, 2019

thanks @kojidev thats what I thought, however I did the following and it is still not working for me...

npm install es6-promise

I created my app with create react app https://facebook.github.io/create-react-app
this is my package.json file...

  "name": "client_portal",
  "version": "0.2.0",
  "private": true,
  "proxy": "http://localhost/",
  "homepage": "/client",
  "dependencies": {
    "bootstrap": "^4.3.1",
    "core-js": "^3.1.3",
    "es6-promise": "^4.2.8",
    "formik": "^1.5.2",
    "iframe-resizer": "^3.6.6",
    "js-cookie": "^2.2.0",
    "mobx": "^4.10.0",
    "moment": "^2.24.0",
    "papaparse": "^4.6.3",
    "prop-types": "^15.7.2",
    "react": "^16.8.6",
    "react-bootstrap-typeahead": "^4.0.0-alpha.9",
    "react-dom": "^16.8.6",
    "react-iframe-resizer-super": "^0.2.2",
    "react-json-view": "^1.19.1",
    "react-redux": "^6.0.1",
    "react-router-dom": "^5.0.0",
    "react-scripts": "2.1.8",
    "react-table": "^6.9.2",
    "reactstrap": "^7.1.0",
    "redoc": "^2.0.0-rc.8-1",
    "redux": "^4.0.1",
    "redux-logger": "^3.0.6",
    "redux-thunk": "^2.3.0",
    "rollbar": "^2.5.4",
    "styled-components": "^4.3.1",
    "underscore": "^1.9.1",
    "underscore.string": "^3.3.5"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": [
    ">0.2%",
    "not dead",
    "not ie <= 11",
    "not op_mini all"
  ]
}

@brendancf
Copy link

OK, I removed core-js and removed node_modules and package-lock.json then reran npm install and its working now.

@RomanHotsiy
Copy link
Member

Thanks! Added as a peer dependency!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants