Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for improvement #2

Open
Reneator opened this issue Jun 2, 2020 · 3 comments
Open

Ideas for improvement #2

Reneator opened this issue Jun 2, 2020 · 3 comments
Assignees

Comments

@Reneator
Copy link
Owner

Reneator commented Jun 2, 2020

I might separrate this ticket into multiple ones depending on topic. Right now this is mainly to keep notes:

As this skill-tree could be used for other things, like "weapon-leveling" "crafting-recipe-tree" "weapon-upgrade-tree" i would try to keep it generalized in a certain way. For this i have an idea to enable multiple nodes connections and the way i can define those:

  • A node can have a cost (which has to be paid on skilling):
    • will provide generic Cost-object to enable seamless integration

(done)
~~

  • A node can have multiple predecessors, for which he can set up how the requirements work:

    • the node can require all the previous nodes to be skilled/leveld
    • the node can require any of the previous nodes to be skilled/leveld~~

(solved by talent-rows)

This can work by having to maybe define a number of the "previous_nodes_required" or something like that.

  • Skilling one node, can lock out another path

I could do this,k by enabling the player to to define another skill-tree-node in the inspector, which would then get locked as this node gets leveled. I could also do this in a way, that it would cascade down the path and lock up all the other nodes as well.

optionals:
A node can have the cost of the previous node or node's object:
for example a weapon_upgrade-tree might require the weapon of the lower tier as a cost (as in consume it). Or maybe there is a simpler solution to it, by having the user define the item as part of the cost directly/by hand.

Maybe also have a locking-preview

@Reneator Reneator self-assigned this Jun 2, 2020
@JamesMWestbrook
Copy link

Aside from adding an optional locking system, I feel like it'd have to be up to the user to decide what specific functionality they need.
I'm loving this base you've made! It's really helpful. Do you have any social media with which I can show you me expanding upon it?

@Reneator
Copy link
Owner Author

Hey mate!
Thanks for sharing!

Its nothing official, but i have a twitter-handle:
@Ronnyism

The code of this repository is now a bit old and i might need to refactor/change some parts to make it more reusable.

@Reneator
Copy link
Owner Author

Reneator commented May 18, 2021

Added the multiple previous-nodes logic (now there is an array you can define multiple nodes). This is also controlled by a selection of "previous_nodes_type" ALL or ANY which will define if only one previuos node has to be learned or ALL.

Also added a Talent-row logic + max_talent_row_selections

Edit: Also Added Line as Scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants