Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading a zipped crate that contains another RO-Crate picks up the wrong metadata #32

Closed
fbacall opened this issue Sep 12, 2024 · 0 comments · Fixed by #36
Closed

Reading a zipped crate that contains another RO-Crate picks up the wrong metadata #32

fbacall opened this issue Sep 12, 2024 · 0 comments · Fixed by #36
Assignees
@fbacall
Labels
bug Something isn't working

Comments

@fbacall
Copy link
Collaborator

fbacall commented Sep 12, 2024

When reading a zip file with a structure:

/ro-crate-metadata.json
/a_directory/ro-crate-metadata.json

the inner /a_directory/ro-crate-metadata.json metadata file is (always?) used, due to the reader doing a depth-first search to find the metadata file.
@fbacall fbacall added the bug Something isn't working label Sep 12, 2024
@fbacall fbacall self-assigned this Sep 12, 2024
@fbacall fbacall mentioned this issue Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbacall fbacall

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use BFS to detect ro-crate-metadata.json ResearchObject/ro-crate-ruby
1 participant
@fbacall