-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Plugin displays bigger image sizes than the max-width of the Theme #21
Comments
hey @florianbrinkmann , I'm having a hard time finding an image that has a srcset attribute. Can you be a little bit more specific on where I can find a place on your site that's using this plugin? |
hi @tevko, of course, sorry. The attached image on the homepage is a featured image and uses the plugin. |
very sorry, is the plugin disabled? I'm not seeing it |
... I think it was a cache-problem, should work now |
I see now. What's happening is that theirs no sizes attribute, which means that the browser thinks the image needs to be 100% wide at all times. You should use regex or a filter to put an appropriate sizes attribute on the image tag. We don't do this with the plugin because we have no way of predicting what those sizes will be |
okay, thanks for your quick help! |
Hi,
at first: Thanks for your work on this plugin, it`s great! :)
I tried it on my blog and it works very fine. But when the viewport is wider than an uploaded full width image (for exapmle 1200px) then the plugin loads this image and the theme scales it down.
You can see it here (for example the featured image for the "the_posts_pagination"-post): http://brinkmannblog.de/
I hope it was understandable :)
Florian
The text was updated successfully, but these errors were encountered: