From 1de817f91363d48a3677a9e8e509fd6c4a474e2c Mon Sep 17 00:00:00 2001 From: NachoSoto Date: Thu, 27 Jul 2023 09:16:49 +0200 Subject: [PATCH] `Logging`: log entire cache key with verbose logs (#2888) --- .../FoundationExtensions/OperationQueue+Extensions.swift | 9 ++++++++- Sources/Logging/Strings/NetworkStrings.swift | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Sources/FoundationExtensions/OperationQueue+Extensions.swift b/Sources/FoundationExtensions/OperationQueue+Extensions.swift index 97b99160ef..a809bcdd3d 100644 --- a/Sources/FoundationExtensions/OperationQueue+Extensions.swift +++ b/Sources/FoundationExtensions/OperationQueue+Extensions.swift @@ -23,7 +23,14 @@ extension OperationQueue { case .firstCallbackAddedToList: self.addOperation(factory.create()) case .addedToExistingInFlightList: - Logger.debug(Strings.network.reusing_existing_request_for_operation(T.self, factory.cacheKey)) + Logger.debug( + Strings.network.reusing_existing_request_for_operation( + T.self, + Logger.logLevel == .verbose + ? factory.cacheKey + : factory.cacheKey.prefix(15) + "…" + ) + ) return } } diff --git a/Sources/Logging/Strings/NetworkStrings.swift b/Sources/Logging/Strings/NetworkStrings.swift index 4db29e49ab..73441c0ee4 100644 --- a/Sources/Logging/Strings/NetworkStrings.swift +++ b/Sources/Logging/Strings/NetworkStrings.swift @@ -62,7 +62,7 @@ extension NetworkStrings: LogMessage { case let .reusing_existing_request_for_operation(operationType, cacheKey): return "Network operation '\(operationType)' found with the same cache key " + - "'\(cacheKey.prefix(15))...'. Skipping request." + "'\(cacheKey)'. Skipping request." case let .creating_json_error(error): return "Error creating request with body: \(error)"