AttributionPoster passes (null) to the backend, consider updates.

[taquitos]

(null) is true to the ObjC code here, maybe we should reject this and not post?
Also, maybe early return too.

https://github.com/RevenueCat/purchases-ios/blob/swift_migration/PurchasesCoreSwift/Attribution/AttributionPoster.swift#L61

It seems like we might be pass (null) to the backend here. Is that a problem?

[taquitos]

Sync with backend folks to see what values they are getting and what they do with them.

[taquitos]

@vegaro just tracked it down, this string can be removed

[NachoSoto]

@taquitos @vegaro can you provide some more context here? I went through the code, and "\(maybeIdentifierForAdvertisers ?? "(null)")_\(networkUserId ?? "(null)")" isn't being sent to the server, only used as a "cache key".

I wonder if this was already solved?

[taquitos]

I think you're right. It looks like this is just used for cache management. It is included in the calls to postSubscriberAttributes and postSearchAds but only as a passthrough to setting the cache. When it is pulled from the cache, the value is only compared to a newly generated value which includes (null) but not directly sent anywhere.

[NachoSoto]

Should we close this then?

[taquitos]

💯