Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI caches are invalid for pull requests #1516

Closed
ferki opened this issue Oct 30, 2021 · 0 comments · Fixed by #1517
Closed

CI caches are invalid for pull requests #1516

ferki opened this issue Oct 30, 2021 · 0 comments · Fixed by #1517
Labels
bug Confirmed bugs

Comments

@ferki
Copy link
Member

ferki commented Oct 30, 2021

Describe the bug

558aa9a introduced a CACHE_VERSION variable to the CI cache key, so the cache could be invalidated by changing the value of that variable (=without committing to the codebase). This variable is defined as a repository secret, which is not available for pull requests from forks.

This causes using a brand new cache for PR from forks, which also means e.g. empty list of known perlcritic violations, leading to accepting the new state whatever it is (via Test::Perl::Critic::Progressive thinking it is its first run).

How to reproduce it

Steps to reproduce the behavior:

  1. Fork the repo
  2. Send a pull request
  3. Check the cache key value in the build log

Shortest code example that demonstrates the bug:

Expected behavior

Pull requests from forks should use the same caches as internal pull requests (and should be tested the same way too).

Circumstances

Debug log

@ferki ferki added triage needed A potential bug that needs to be reproduced and understood bug Confirmed bugs and removed triage needed A potential bug that needs to be reproduced and understood labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant