feat: support stripping internal types #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... using `@internal` JSDoc tags, if the `stripInternal` tsconfig compiler option is enabled. This means types annotated with `@internal` will be stripped both from .js/ts files going through the TS program aswell as d.ts files going through our logic part of sveltejs/svelte#12292
|
I have no idea what's going on with CI, but all tests passed locally for me (maybe someone with a non-windows system should run them too, just to make sure) |
|
it seems unrelated to the PR — passed for me locally too. maybe we just try again tomorrow? 
|
|
No idea why the setup action was pinned to an old version - that was the problem, there was an error fixed in a later version of 2.x recently, but I don't see a reason to not just bump to v4 instead. Anyway, this is good to go now. |
This was referenced Aug 22, 2024
|
published! great addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... using
@internalJSDoc tags, if thestripInternaltsconfig compiler option is enabled. This means types annotated with@internalwill be stripped both from .js/ts files going through the TS program aswell as d.ts files going through our logicpart of sveltejs/svelte#12292
fixes #63