Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Artwork #419

Open
niklaskorz opened this issue Apr 27, 2020 · 10 comments
Open

Cover Artwork #419

niklaskorz opened this issue Apr 27, 2020 · 10 comments

Comments

@niklaskorz
Copy link

In certain terminal emulators, for example Kitty, graphics can be displayed. It might be worth discovering this as an option to display the cover art in the spotify-tui interface. I'd be willing to implement this myself as a pull request if there's interest.

@Rigellute
Copy link
Owner

It would be awesome to get the album art rendered in the terminal. I've actually looked into this before but couldn't figure it out. There is an open question in tui for this exact issue fdehau/tui-rs#143

But please do have a crack at it!

@niklaskorz
Copy link
Author

The ranger source code is a pretty good hint and shows that there's no single "correct" solution to this: https://github.com/ranger/ranger/blob/master/ranger/ext/img_display.py

I think it makes sense to wrap the most commonly used solutions in a general tui-rs widget and let the user opt-in to any of the provided solutions.

As an experiment, I have taken ranger's implementation as an inspiration and implemented a basic ueberzug image widget in tui-rs:

image

@niklaskorz
Copy link
Author

niklaskorz commented Apr 29, 2020

To be clear, except for Kitty and iTerm2, this would rely on calling external programs that draw on top of the actual terminal. From what I have seen, only Kitty and iTerm2 support real drawing of graphics directly in the terminal.

@ghost
Copy link

ghost commented May 20, 2020

Screenshot_20200520_221911

Covers could be generated as ANSi and rendered in any terminal emulator.

@jerbaroo
Copy link

Covers could be generated as ANSi and rendered in any terminal emulator.

Would this solution only work for displaying artwork in full screen or over large portions of the screen? It wouldn't be suitable for displaying the artwork of the current song in the bottom corner of the spotify-tui?

@ghost
Copy link

ghost commented Aug 24, 2020

Would this solution only work for displaying artwork in full screen or over large portions of the screen?

I'm not sure of the design details just floating the concept that all terminal emulators can have covers if ANSi is used.

@eoli3n
Copy link

eoli3n commented Dec 2, 2020

Any news about this ?

@atanunq
Copy link

atanunq commented Dec 2, 2020

This thread inspired me to create viuer but for now it only has support for Kitty and questionable cross-platform capabilities. If support for iTerm is added I believe it would be a good candidate for the work here.

Edit: iTerm support is finished.

@apprehensions
Copy link

anything new? i've been looking forward to switching to spotify-tui but this has been holding me back.

@Icelk
Copy link

Icelk commented Nov 28, 2022

I've made a fork which adds support for this using the kitty graphics protocol. The code is very hacky, but it works without any major bugs.

https://github.com/Icelk/spotify-tui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants