Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NSLinkAttributeName #150

Closed
angelmixu opened this issue Jun 1, 2016 · 4 comments · Fixed by #154
Closed

Support NSLinkAttributeName #150

angelmixu opened this issue Jun 1, 2016 · 4 comments · Fixed by #154

Comments

@angelmixu
Copy link

It would be cool if for example I have:

"You accept the Terms Of Service"

with 'Terms Of Service' clickable and calling some handler/action for opening links, segue, or doing something.

@ZevEisenberg
Copy link
Collaborator

I believe the link tapping would have to be handled by a UITextView or perhaps TTTAttributedLabel. But BonMot could certainly support adding NSLinkAttributeName to a string. Would you be interested in adding a pull request to that effect, @angelmixu?

@angelmixu
Copy link
Author

Yup, I was looking for an overpowered UILabel in Swift and just got to TTTAttributedLabel and BonMot, I liked a lot BonMot but lacked touch sections.
@ZevEisenberg right now I'm quite busy, but in some time I'll be glad to try to implement it :)

@ZevEisenberg ZevEisenberg changed the title Ability to open links from some range Support NSLinkAttributeName Jun 1, 2016
@ZevEisenberg
Copy link
Collaborator

I've renamed this issue, because I think adding NSLinkAttributeName is a great idea and I'd like it to be a part of BonMot. I'll try to get to it soon, but if someone else wants to add it, I'm happy to help if you get stuck.

@ZevEisenberg
Copy link
Collaborator

To clarify: I probably won't add link-tapping detection to BonMot. It should be easy to use BonMot to generate the link (once this issue is closed), and then pass the attributed string on to TTTAttributedLabel or UITextView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants