-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming of data dragon champion tile images is inconsistent #83
Comments
how we doing 3 years later fellas? |
Hey! Thanks for responding. Fiddlesticks lists his image name as "Fiddlesticks.png" in http://ddragon.leagueoflegends.com/cdn/13.24.1/data/en_US/champion.json. That seems to match your case, right? Am I missing something? Seems like this issue is unrelated. |
sorry i had to be more specific. |
That's not this issue. This issue is that the tiles image have several images with the same case-insensitive name, and no reference from the champion.json to the right one. Your issue is that the key of the Riot API (not mentioned in the original issue) does not case-sensitively match the key of the champion image, nor the key of the one in champion.json. |
This is the solution to your issue, on top of using championId rather than championName: #7 (comment) |
Wow, ok, I didn't expect to have to go through an additional layer. Thanks! |
Fiddlesticks does not work as champion key:
https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/Fiddlesticks_0.jpg //does not work
https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/FiddleSticks_0.jpg //does work
https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/fiddlesticks_0.jpg //does work
Ddragon tile images are named inconsistently. The latest champions (Sylas and Neeko) have only been uploaded with champion key (where it was previously only full lowercase, I believe).
Not really a big problem, but still annoying.
The text was updated successfully, but these errors were encountered: