Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of data dragon champion tile images is inconsistent #83

Open
meesvandongen opened this issue Feb 12, 2019 · 6 comments
Open

Naming of data dragon champion tile images is inconsistent #83

meesvandongen opened this issue Feb 12, 2019 · 6 comments
Labels
pending: acknowledged We're aware of this issue and are investigating. topic: ddrag lol League of Legends Data Dragon type: inconsistency Typos, dead links, out dated information, or weird behavior.

Comments

@meesvandongen
Copy link

Fiddlesticks does not work as champion key:
https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/Fiddlesticks_0.jpg //does not work
https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/FiddleSticks_0.jpg //does work
https://ddragon.leagueoflegends.com/cdn/img/champion/tiles/fiddlesticks_0.jpg //does work

Ddragon tile images are named inconsistently. The latest champions (Sylas and Neeko) have only been uploaded with champion key (where it was previously only full lowercase, I believe).

Not really a big problem, but still annoying.

@RiotTuxedo RiotTuxedo added pending: acknowledged We're aware of this issue and are investigating. topic: ddrag lol League of Legends Data Dragon type: inconsistency Typos, dead links, out dated information, or weird behavior. labels Feb 15, 2019
@RiotTuxedo RiotTuxedo changed the title Naming of champions in ddragon tile images is inconsistent Naming of data dragon champion tile images is inconsistent Feb 15, 2019
@geozukunft geozukunft mentioned this issue Jun 15, 2023
@KonssnoK
Copy link

how we doing 3 years later fellas?
http://ddragon.leagueoflegends.com/cdn/13.24.1/img/champion/FiddleSticks.png
vs
https://ddragon.leagueoflegends.com/cdn/13.24.1/img/champion/Fiddlesticks.png

@Querijn
Copy link

Querijn commented Dec 10, 2023

Hey! Thanks for responding.

Fiddlesticks lists his image name as "Fiddlesticks.png" in http://ddragon.leagueoflegends.com/cdn/13.24.1/data/en_US/champion.json. That seems to match your case, right? Am I missing something? Seems like this issue is unrelated.

@KonssnoK
Copy link

KonssnoK commented Dec 10, 2023

sorry i had to be more specific.
match data championName reports fiddlestick name as FiddleSticks, while in the ddragon data the image is under Fiddlesticks,
suggesting that the inconsistencies are still there :)

@Querijn
Copy link

Querijn commented Dec 10, 2023

That's not this issue. This issue is that the tiles image have several images with the same case-insensitive name, and no reference from the champion.json to the right one.

Your issue is that the key of the Riot API (not mentioned in the original issue) does not case-sensitively match the key of the champion image, nor the key of the one in champion.json.

@Querijn
Copy link

Querijn commented Dec 10, 2023

This is the solution to your issue, on top of using championId rather than championName: #7 (comment)

@KonssnoK
Copy link

Wow, ok, I didn't expect to have to go through an additional layer. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending: acknowledged We're aware of this issue and are investigating. topic: ddrag lol League of Legends Data Dragon type: inconsistency Typos, dead links, out dated information, or weird behavior.
Projects
None yet
Development

No branches or pull requests

4 participants