Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service-worker in Carlo? #164

Closed
roosmaa opened this issue Jan 2, 2019 · 1 comment
Closed

Service-worker in Carlo? #164

roosmaa opened this issue Jan 2, 2019 · 1 comment
Assignees
@roosmaa
Labels
question Further information is requested

Comments

@roosmaa
Copy link
Contributor

roosmaa commented Jan 2, 2019

I saw in one of the issues an error about service worker registration. But in Carlo context, the service worker doesn't make much sense to me. It can potentially only introduce bugs (eg. the user updates the desktop binary and has to restart it because service worker still had the old assets cached [hypothetical, haven't tested]). So maybe we should not register the service worker when running in Carlo context?

// @TobiaszCudnik
@roosmaa roosmaa added the question Further information is requested label Jan 2, 2019
@TobiaszCudnik
Copy link
Contributor

Yes, ideally we would backport this PR with typeof carlo detection.

@roosmaa roosmaa closed this as completed in 3d89d17 Jan 3, 2019
TobiaszCudnik added a commit that referenced this issue Jan 23, 2019
@TobiaszCudnik
fix service worker registration regression from #164
151cc09
TobiaszCudnik added a commit that referenced this issue Jan 29, 2019
@TobiaszCudnik
fix service worker registration regression from #164
a3d2a67
TobiaszCudnik added a commit that referenced this issue Jan 29, 2019
@TobiaszCudnik
show the disconnected icon when not online #164
c8e7a8e
TobiaszCudnik added a commit that referenced this issue Feb 4, 2019
@TobiaszCudnik
show the disconnected icon when not online #164
4d0781b
TobiaszCudnik added a commit that referenced this issue Feb 4, 2019
@TobiaszCudnik
show the disconnected icon when not online #164
c274f4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roosmaa roosmaa

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roosmaa @TobiaszCudnik