Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gesturefy does not recognize links embeded in Youtube video thumbnails #684

Closed
tommobile14 opened this issue Sep 18, 2023 · 3 comments
Closed
Labels

Comments

@tommobile14
Copy link

Windows 10, Firefox 117 64.

I have a gesture to Open Link in new Tab. It works fine in most situations. But on Youtube Main page, the gesture only works if I initiate it from the video title (the words part), but does nothing if I initiate it from the video thumbnail. Even though both the title and the thumbnail follow the same link.

The odd thing is, if I already open a Youtube video and then initiate the gesture on the Suggestion video thumbnails on the side, it works.

This issue is only with Youtube Main page. Gesturefy works fine with other video thumbnails on other platforms like Vimeo or Twitter.

@Robbendebiene
Copy link
Owner

Hi thanks for the detailed report.
I think I can fix this.

The reason is that youtube only activates the thumbnail link on mouseover, but Gesturefy is collecting the data at the end of the gesture (at this time youtube has removed the link).

This bug has been occurred before but was fixed back then. It probably reoccurred because of youtubes new "live preview" I wonder if I had a good reason not to gather all the data on gesture start and rather did it on gesture end 🙈

@tommobile14
Copy link
Author

Thank you for the reply.

If "Gesturefy is collecting the data at the end of the gesture" then how does it understand when the gesture starts from the link itself? Surely it has to collect data both from the start and the end of the gesture?

I actually just tried to do the same gesture, this time starting from outside and inside the thumbnail, making sure both gestures end on the thumbnail. Both fail to register.

Hope you'll iron out this bug. Great work on this add-on.

@Robbendebiene
Copy link
Owner

If "Gesturefy is collecting the data at the end of the gesture" then how does it understand when the gesture starts from the link itself? Surely it has to collect data both from the start and the end of the gesture?

When a gesture is performed Gesturefy stores the starting point element. But the actual collection/extraction of the data from the element (like the link url) happened when the gesture was finished. At this moment though the element might have been removed or altered by the website.

This should be fixed in the new Gesturefy version 3.2.9 which should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants