Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine does not start on some Windows 10/11 laptops #743

Closed
RobertBeckebans opened this issue Feb 20, 2023 · 3 comments
Closed

Engine does not start on some Windows 10/11 laptops #743

RobertBeckebans opened this issue Feb 20, 2023 · 3 comments
Labels

Comments

@RobertBeckebans
Copy link
Owner

This has been reported several times and also applies for the original BFG edition. It seems to be a bug in the Display enumerator code.

@Calinou
Copy link

Calinou commented Feb 20, 2023

With Vulkan, this could be similar to godotengine/godot#57708 if the issue is scoped to AMD integrated + NVIDIA dedicated GPU configurations.

@RobertBeckebans
Copy link
Owner Author

Thanks for the hint. I have a new notebook where I can finally reproduce the problem.

I think the problem in the BFG code is here:

       if( !( device.StateFlags & DISPLAY_DEVICE_ATTACHED_TO_DESKTOP ) )
        {
            continue;
        }

@RobertBeckebans
Copy link
Owner Author

Well in my case it was that my notebook display only supports 165 Hz and the BFG edition usually discards all resolutions that don't support 60 and 120 Hz.

I also extended the code to check for:

if( !( device.StateFlags & ( DISPLAY_DEVICE_ATTACHED_TO_DESKTOP | DISPLAY_DEVICE_PRIMARY_DEVICE ) ) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants