You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
As part of the Android first functional apk, we want to be able to store data as we do with cookies on web, but using Android's persistent storage.
Describe the solution you'd like
The same way we implementedApiWebClient/ApiNativeClient, we must create:
SystemWebClient: It allows to get/write/delete data from cookies
SystemNativeClient: It allows to get/write/delete data from Android's persistent storage.
flowchart LR
SystemClient <--> SystemWebClient
SystemClient <--> SystemNativeClient
SystemNativeClient <--> react-native
react-native <--> PersistedStorage
SystemWebClient <--> Cookies
Watch out! with the Native client, this data needs to be obtained through Promises, this will require to change a lot of logic on the app, which right now assumes the way to obtain cookies is synchronous.
The text was updated successfully, but these errors were encountered:
Watch out! with the Native client, this data needs to be obtained through Promises, this will require to change a lot of logic on the app, which right now assumes the way to obtain cookies is synchronous.
Indeed, there is quite a few checks the app performs synchronously in several components to detect whether the user has an active robot. It would have to be adapted.
I think this approach is perfect. Once the SystemWebClient / SystemNativeClient libraries are in place, there is a lot of functionality that can be extracted from them on top to just cookies. For example have persistent user settings: dark/light mode, language, fontSize (UI size), etc.
The approach seems great to be extended in the future with a SystemNodeClient to allow for persistent storage in the node app (e.g., Umbrel).
This and #257 can be combined into a single rewarded task. Let's put a little incentive on it of ⚡600 K Sats⚡. I am assigning you.
Is your feature request related to a problem? Please describe.
As part of the Android first functional apk, we want to be able to store data as we do with cookies on web, but using Android's persistent storage.
Describe the solution you'd like
The same way we implemented
ApiWebClient
/ApiNativeClient
, we must create:SystemWebClient
: It allows to get/write/delete data from cookiesSystemNativeClient
: It allows to get/write/delete data from Android's persistent storage.Describe alternatives you've considered
Because of this react-native-webview/react-native-webview#2643 using cookies on WebView won't work
Additional context
Keep in mind this message structure is for HTTP requests https://github.com/Reckless-Satoshi/robosats/pull/247/files#diff-cc3020823102c0ca6d5e5f5b49c0b9eecdb94b3b51cb89cafdc754b8b777ca87R14 we must create an different structure for the system actions.
Watch out! with the Native client, this data needs to be obtained through Promises, this will require to change a lot of logic on the app, which right now assumes the way to obtain cookies is synchronous.
The text was updated successfully, but these errors were encountered: