Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpplint: Should use more up-to-date fork, not from styleguide #10266

Closed
EricCousineau-TRI opened this issue Dec 18, 2018 · 4 comments
Closed

Comments

@EricCousineau-TRI
Copy link
Contributor

Per this issue: google/styleguide#408

Consider the fork at https://github.com/cpplint/cpplint (also published to Pypi) if you feel like contributing.

\cc @jwnimmer-tri @jamiesnape

@jamiesnape
Copy link
Contributor

Don't think I agree. We already fork ourselves, so it is not buying us anything.

@EricCousineau-TRI
Copy link
Contributor Author

Yes, it may have additional overhead of configurations changing, but it may have improvements codewise that we may want at some point.

I'd call this closeable if we at least put a comment at the top of our forked cpplint pointing to the new stuff.

@jamiesnape
Copy link
Contributor

I'd call this closeable if we at least put a comment at the top of our forked cpplint pointing to the new stuff.

Sounds a little strange. I don't we should be deviating too much anyway unless the Google version is broken, whether to not there are improvements.

@EricCousineau-TRI
Copy link
Contributor Author

Aye. Will close then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants