Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADS-1687: #2

Merged
merged 2 commits into from
Apr 18, 2018
Merged

ADS-1687: #2

merged 2 commits into from
Apr 18, 2018

Conversation

ArmandChoy
Copy link

@ArmandChoy ArmandChoy commented Apr 18, 2018

- Modified rockyouBidAdapter.js to sort sizes by area before selecting.
- Updated the rockyouBidAdapter_spec.js

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Armand Choy added 2 commits April 17, 2018 18:36
    - Modified rockyouBidAdapter.js to sort sizes by area before selecting.
    - Updated the rockyouBidAdapter_spec.js
    - Updated spacing and switched to use an arrow functiuon.
@ArmandChoy ArmandChoy merged commit d2bf430 into master Apr 18, 2018
ArmandChoy pushed a commit that referenced this pull request May 15, 2018
* add video&native traffic colossus ssp

* Native obj validation

* Native obj validation #2

* Added size field in requests

* fixed test
ArmandChoy pushed a commit that referenced this pull request May 15, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* Pulsepoint Bid Adapter - GDPR support

* minor update

* minor update

* Fixing review comment
ArmandChoy pushed a commit that referenced this pull request Sep 28, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* GDPR Bug Fix with String response

* minor
ArmandChoy pushed a commit that referenced this pull request Sep 28, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* GDPR Bug Fix with String response

* minor

* Fixing iframe page test

* Fixing lint error
ArmandChoy pushed a commit that referenced this pull request Sep 28, 2018
* PET-239 IAS bid adapter multiple slot fix (#1)

* PET-239 Fix.
Performs the request for multiple slots on 1 call.

* PET-239 Fixed Prebid tests

* PET-239 Additional unit tests

* Fixed errors for PR 2653 (#2)

* Pet 239 ias bid adapter bug fix for multiple slots (#3)

* Fixed errors for PR 2653

* Removed unnecessary block from iasBidAdapter from the comments in pull
2653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants