Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker hub repo -Which one is really official ? #112

Closed
jsalatiel opened this issue May 15, 2020 · 4 comments
Closed

Docker hub repo -Which one is really official ? #112

jsalatiel opened this issue May 15, 2020 · 4 comments

Comments

@jsalatiel
Copy link

There are https://hub.docker.com/_/rocket-chat?tab=tags and https://hub.docker.com/r/rocketchat/rocket.chat/tags. Which one is official docker repo? One seems to be twice bigger than the other.

@aminvakil
Copy link
Contributor

Both.

https://github.com/RocketChat/Rocket.Chat#docker

https://hub.docker.com/_/rocket-chat is a release approved by docker team too, therefore it will be always older (from my experience about two weeks) than the rocketchat official one.

But interesting point you've mentioned about size, I don't know either.

@jsalatiel
Copy link
Author

@sampaiodiego Do you know why the size is different ?

@jsalatiel
Copy link
Author

One thing that I also have noticed is that one of the repos has a much more vulnerable image when scanned by Clair. 3.2.2 is the one approved by docker team.
image

@sampaiodiego
Copy link
Member

@sampaiodiego Do you know why the size is different ?

the size difference is because they are built from very different Dockefiles (docker official and rocket.chat). the same applies to vulnerabilities as they depend on different base images.

we've discussed a few times if we should have only one Docker image.. the main issue is that sometimes we want to published "special images" or images used for testing purposes, in this cases the "official docker" images are not suitable for.

I'll at least try to use a more close Dockerfile for both images, it will reduce the differences (either in size and vulnerabilities) between them and also help maintainability 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants