Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] : Deploy PR Previews to GitHub Pages #617

Closed
1 task
devanshkansagra opened this issue Aug 13, 2024 · 7 comments · Fixed by #620
Closed
1 task

[Feat] : Deploy PR Previews to GitHub Pages #617

devanshkansagra opened this issue Aug 13, 2024 · 7 comments · Fixed by #620
Labels
enhancement New feature or request epic this is a must have feature

Comments

@devanshkansagra
Copy link
Contributor

devanshkansagra commented Aug 13, 2024

As an EmbeddedChat developer

I need to:
Deploy the preview of the changes made in a pull request to Github Pages

So That:
Maintainers and other users can get to see and review the output before it gets merged

Acceptance Criteria

  • Deploy the changes made in pull request to Github pages

Rough Example
Make it something like this: https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr-number>/

@devanshkansagra devanshkansagra added the enhancement New feature or request label Aug 13, 2024
@devanshkansagra
Copy link
Contributor Author

Hey @sidmohanty11 and @Spiral-Memory, I am working on this !

@Spiral-Memory
Copy link
Collaborator

Sure @devanshkansagra

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, which projects of monrepo do we have to add in this?

@Spiral-Memory
Copy link
Collaborator

For all (but for a start, you can test for Embedded Chat (as that's the most important one)

@devanshkansagra
Copy link
Contributor Author

No I am talking about, do I add react, layout-editor, ui-elements?? or all??

@Spiral-Memory
Copy link
Collaborator

All (for testing, react is fine, but we need all)

@devanshkansagra
Copy link
Contributor Author

ok

@devanshkansagra devanshkansagra changed the title [Feat] : Implement the deployment preview of changes made in the pull request to GitHub Pages. [Feat] : Deploy PR Previews to GitHub Pages Aug 23, 2024
@Spiral-Memory Spiral-Memory added the epic this is a must have feature label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic this is a must have feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants